Am Dienstag, 18. Juli 2017, 10:47:00 CEST schrieb Arnd Bergmann:
Hi Arnd,
> On Tue, Jul 18, 2017 at 10:37 AM, Stephan Müller <smueller@xxxxxxxxxx>
wrote:
> > Am Dienstag, 18. Juli 2017, 10:13:55 CEST schrieb Arnd Bergmann:
> >> On Tue, Jul 18, 2017 at 9:58 AM, Stephan Müller <smueller@xxxxxxxxxx>
wrote:
> >> > When selecting the LRNG for compilation, disable add_disk_randomness
> >> > and
> >> > its supporting function.
> >> >
> >> > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> > CC: Arnd Bergmann <arnd@xxxxxxxx>
> >> > CC: Jason A. Donenfeld <Jason@xxxxxxxxx>
> >> > Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx>
> >>
> >> I think this needs a better explanation. Why do we ignore the extra
> >> entropy here?
> >
> > I was not sure whether to add all the details about the reason into the
> > patch submission.
> >
> > The reason is explained here in [1] page 3 and re-iterated in [2].
>
> Ok, got it. A half-sentence summary of that ("... to avoid adding the
> same event twice from interrupt and block") would be sufficient for
> the patch description, longer is also fine.
Perfect, thank you for that hint. I will add this information to a next
iteration.
>
> Generally speaking, each patch description should describe why
> that particular patch is required rather than describe what it does
> (which in cases like this is plain to see from looking a few lines
> down).
>
> Arnd
Ciao
Stephan
