On 18 July 2017 at 09:39, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Jul 10, 2017 at 02:45:48PM +0100, Ard Biesheuvel wrote: >> There are quite a number of occurrences in the kernel of the pattern >> >> if (dst != src) >> memcpy(dst, src, walk.total % AES_BLOCK_SIZE); >> crypto_xor(dst, final, walk.total % AES_BLOCK_SIZE); >> >> or >> >> crypto_xor(keystream, src, nbytes); >> memcpy(dst, keystream, nbytes); > > What keeping crypto_xor as it is and adding a new entry point for > the 4-argument case? > Also fine.
