On Tue, Jul 18, 2017 at 10:40:07AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:30:14 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > > +typedef unsigned long long __u64; > > > +typedef long long __s64; > > > > types.h already has these defines, don't re-typedef them again... > > The issue is that the C code is compiled without optimizations. Thus, the C > code shall not depend on any other header file. That is very strange for a kernel file, I don't know what to say... > This issue was discussed during the inclusion of the Jitter RNG C code into > the kernel. Ok, that was then, this is now, why not change it now? How does including types.h change anything? thanks, greg k-h
