On Thu, Jun 23, 2016 at 08:25:05AM -0700, Tadeusz Struk wrote: > > The reason why mpi_write_to_sgl() strips the leading zeros is only > because we said that it needs to work in the same way as the > mpi_read_buffer(), which does remove it for whatever reason. > So should we now change the mpi_read_buffer() as well? Didn't we add mpi_read_buffer specifically for akcipher before we switched over to SGs? If nobody is using it we should just delete it. > We also need to change the qat rsa implementation because it does remove > zeros as well, but it will be very easy to do. The way it's done with my patches you don't have to do the conversion right away because it'll cope with either stripping or not stripping leading zeroes. But yes it should simplify the code in qat so please send in patches when you have time. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
