Hi Herbert, On 06/22/2016 03:14 AM, Herbert Xu wrote: > This was prompted by the caam RSA submission where a lot of work > was done just to strip the RSA output of leading zeroes. This is > in fact completely pointless because the only user of RSA in the > kernel then promptly puts them back. > > This patch series resolves this madness by simply leaving any > leading zeroes in place. The reason why mpi_write_to_sgl() strips the leading zeros is only because we said that it needs to work in the same way as the mpi_read_buffer(), which does remove it for whatever reason. So should we now change the mpi_read_buffer() as well? The mpi_read_buffer() is called from mpi_get_buffer(), which is used only by lib/digsig.c We also need to change the qat rsa implementation because it does remove zeros as well, but it will be very easy to do. Thanks, -- TS -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
