> -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, June 22, 2016 11:04 AM > To: Benedetto, Salvatore <salvatore.benedetto@xxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v10 2/3] crypto: kpp - Add DH software implementation > > On Wed, Jun 22, 2016 at 08:18:42AM +0000, Benedetto, Salvatore wrote: > > > > If I have to pack the secret into a bytestream, where do you expect > > the endianness of the sizes to be handled? If I understood you > > correctly I'll pack them in little endian, but when decoding I have to > > take that into account. Wouldn't that result in pointless endianness > management in the decode functions? > > It is not pointless if it means that we can have a single test function like most > other types. It is pointless because it will only be used for the testmanager. I can merge the test functions but I'll still have two set_secret functions based on the alg value. Would that be enough for you? Regards, Salvatore -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
