Hi Herbert, > -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, June 22, 2016 7:41 AM > To: Benedetto, Salvatore <salvatore.benedetto@xxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v10 2/3] crypto: kpp - Add DH software implementation > > On Wed, Jun 22, 2016 at 06:37:50AM +0000, Benedetto, Salvatore wrote: > > > > Can you explain me the benefit in doing so? > > The less code we have the better. Most of our algorithm types have a single > test function, I have seen no reason why kpp should be different. > > akcipher has been an anomaly and I'm fixing it right now. > Can't I send a smaller patch afterwards just for that? > > I thought my patchset had reached an 'acceptable' state by now :-) > > Now that the secret is encoded to a format under our control, you can > generate byte-stream test vectors for both DH and ECDH using the same > format. So there is no need to have test functions specific to one algorithm. If I have to pack the secret into a bytestream, where do you expect the endianness of the sizes to be handled? If I understood you correctly I'll pack them in little endian, but when decoding I have to take that into account. Wouldn't that result in pointless endianness management in the decode functions? Regards, Salvatore -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
