RE: [PATCH v10 2/3] crypto: kpp - Add DH software implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: linux-crypto-owner@xxxxxxxxxxxxxxx [mailto:linux-crypto-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Herbert Xu
> Sent: Wednesday, June 22, 2016 1:51 AM
> To: Benedetto, Salvatore <salvatore.benedetto@xxxxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v10 2/3] crypto: kpp - Add DH software implementation
> 
> On Tue, Jun 21, 2016 at 09:45:30PM +0100, Salvatore Benedetto wrote:
> >
> > +
> > +static int test_dh(struct crypto_kpp *tfm, struct kpp_testvec_dh *vecs,
> > +		   unsigned int tcount)
> > +{
> > +	int ret, i;
> 
> Please make the kpp test function generic.  I'm trying to kill the RSA-specific
> test function right now and I don't want to have to do this again.
> 

Can you explain me the benefit in doing so?

I thought my patchset had reached an 'acceptable' state by now :-)

Thanks,
Salvatore


> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the
> body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux