Re: [PATCH] crypto: algif - Mark sgl end at the end of data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 01, 2014 at 06:53:41AM -0800, Tadeusz Struk wrote:
> Hi Herbert,
> On 12/01/2014 06:40 AM, Herbert Xu wrote:
> >> +			nents = sg_nents(ctx->rsgl.sg);
> >> > +			sg_mark_end(&sg[nents - 1]);
> > Huh? You're getting nents from the RX side and using it to mark
> > the TX side? This makes no sense because RX may have no relationship
> > whatsoever with TX.
> 
> Yes, but there shouldn't be more nents with data to be processed in TX
> than nents in RX and in most cases they should be equal. Or am I missing
> something?

As I said the two are arbitrary and we don't place any restrictions
on them at all (apart from the fact that the TX length in bytes must
obviously be longer than the RX bytes).

So you can have a 1-element TX list with a multi-element RX list.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux