RE: [RFC PATCH v2] Add VMAC(AES) to Linux for intel_txt support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Herbert Xu wrote:
> On Tue, Aug 11, 2009 at 01:05:57AM +0800, Shane Wang wrote:
>> 
>> For the comment
>>> This is unnecessary.  Please use the standard kernel helpers
>>> from asm/byteorder.h (which you get by including linux/kernel.h).
>> The current code distinguishes some macro implementations according
>> to different platforms to improve the MACing speed, which is one of
>> the reasons VMAC is very fast for MACing. Do we need to give these
>> up? 
> 
> I'm talking about your macros such as get64BE/get64LE.  We have
> identical standard kernel helpers be64_to_cpu/le64_to_cpu which
> should already be optimal.
> 
> Cheers,

OK, I will update.

Thanks for the comment.

Shane--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux