On Tue, Aug 11, 2009 at 01:05:57AM +0800, Shane Wang wrote: > > For the comment > > This is unnecessary. Please use the standard kernel helpers > > from asm/byteorder.h (which you get by including linux/kernel.h). > The current code distinguishes some macro implementations according to > different platforms to improve the MACing speed, which is one of the > reasons VMAC is very fast for MACing. Do we need to give these up? I'm talking about your macros such as get64BE/get64LE. We have identical standard kernel helpers be64_to_cpu/le64_to_cpu which should already be optimal. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
