On Fri, Jun 05, 2009 at 11:34:30AM +0200, Steffen Klassert wrote: > > In pcrypt_alloc_instance() I do > inst->alg.cra_priority = alg->cra_priority + 100; > > So, in my case authenc has priority 2000 and pcrypt has priority 2100. > In this case pcrypt is not instantiated if I use %s for pcrypt as > cra_name. If I do > inst->alg.cra_priority = alg->cra_priority - 100 > it will be instantiated with priority 1900 but it will not be used > because the priority of authenc is higher. > > So I did the priority check in crypto_alg_tested() the other way around. > Then I can instantiate pcrypt with priority 2100 and I can use it. Can you send me a pcrypt patch that I can use to reproduce this? The check modified is meant to replace instances of the same implementation (i.e., you're replaceing aes-x86-64 with a newer version of aes-x86-64). It should never do anything when you add a different implementation of the same algorithm. So I'm surprised that you're seeing a difference when changing that check. Because unless you're creating two pcrypt objects with the same driver name, or your pcrypt object has the wrong driver name, then this change should make no difference whatsoever. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
