On Wed, Jun 03, 2009 at 01:23:53PM +0200, Steffen Klassert wrote: > On Wed, Jun 03, 2009 at 07:40:50PM +1000, Herbert Xu wrote: > > > > I see. How about if we let tcrypt test algorithms by name, e.g., > > something like > > > > modprobe tcrypt alg='pcrypt(authenc(hmac(sha1),cbc(aes))' > > > > I'm not that sure whether this does what I want. > > If pcrypt has cra_name = pcrypt(authenc(hmac(sha1),cbc(aes))) this > would instatiate this algorithm, but esp wants an algorithm with > cra_name = authenc(hmac(sha1),cbc(aes)). > These names are not matching, so __crypto_alg_lookup() will not > choose for the pcrypt version regardless of the higher priority. When pcrypt instantiates an algorithm, it should set cra_name to %s and cra_driver_name to pcrypt(%s). So as long as the pcrypt priority is higher than the underlying algorithm, it should all work. See for instance how cryptd does it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
