On Fri, Jun 05, 2009 at 07:20:21PM +1000, Herbert Xu wrote: > On Fri, Jun 05, 2009 at 11:20:30AM +0200, Steffen Klassert wrote: > > > > As it is, I can instantiate pcrypt if the priority of pcrypt is lower > > than the priority of the underlying algorithm. If I do the priority > > check in crypto_alg_tested() the other way arround, I get it to work if > > pcrypt has a higher priority than the underlying algorithm. So I guess > > we need the patch below, right? If so, I would send a signed-off patch. > > Can you give me an example with actual numbers and what you expect > to happen? > In pcrypt_alloc_instance() I do inst->alg.cra_priority = alg->cra_priority + 100; So, in my case authenc has priority 2000 and pcrypt has priority 2100. In this case pcrypt is not instantiated if I use %s for pcrypt as cra_name. If I do inst->alg.cra_priority = alg->cra_priority - 100 it will be instantiated with priority 1900 but it will not be used because the priority of authenc is higher. So I did the priority check in crypto_alg_tested() the other way around. Then I can instantiate pcrypt with priority 2100 and I can use it. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html