On Thu, Jan 15, 2009 at 05:30:51PM +0800, Huang Ying wrote: > > > > Why do we need this check? Someone else may register cryptd template? > > > Which error number should be return? -EINVAL? > > > > -ENOMEM for example. > > You mean something as follow: > > if (crypto_ablkcipher_tfm(tfm)->__crt_alg->cra_module != THIS_MODULE) > return ERR_PTR(-ENOMEM); No I meant that crypto_alloc_ablkcipher can return -ENOMEM. If the check fails you should return -EINVAL. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
