On Thu, Jan 15, 2009 at 05:21:47PM +0800, Huang Ying wrote: > On Thu, 2009-01-15 at 16:47 +0800, Herbert Xu wrote: > > On Thu, Jan 15, 2009 at 04:28:33PM +0800, Huang Ying wrote: > > > > > > + tfm = crypto_alloc_ablkcipher(cryptd_alg_name, type, mask); > > > + BUG_ON(crypto_ablkcipher_tfm(tfm)->__crt_alg->cra_module != > > > + THIS_MODULE); > > > > You need to check whether tfm is an error before dereferencing it. > > Also it's probably better to free the tfm and return an error rather > > than invoking BUG. > > Why do we need this check? Someone else may register cryptd template? > Which error number should be return? -EINVAL? -ENOMEM for example. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
