On Thu, 2009-01-15 at 16:47 +0800, Herbert Xu wrote: > On Thu, Jan 15, 2009 at 04:28:33PM +0800, Huang Ying wrote: > > > > + tfm = crypto_alloc_ablkcipher(cryptd_alg_name, type, mask); > > + BUG_ON(crypto_ablkcipher_tfm(tfm)->__crt_alg->cra_module != > > + THIS_MODULE); > > You need to check whether tfm is an error before dereferencing it. > Also it's probably better to free the tfm and return an error rather > than invoking BUG. Why do we need this check? Someone else may register cryptd template? Which error number should be return? -EINVAL? > > --- a/include/crypto/algapi.h > > +++ b/include/crypto/algapi.h > > Please create a new file for this, e.g., include/crypto/cryptd.h. OK. I will do that. Best Regards, Huang Ying
Attachment:
signature.asc
Description: This is a digitally signed message part
