On Tue, May 13, 2008 at 01:27:27PM -0700, Loc Ho wrote: > > Please note: > 1. ahash_request has an extra variable 'void *info' for future uses with > KASUMI That's fine. We can change this structure at will. > 2. Any particular reason for removing ahash_nosetkey from function > crypto_init_ahash_ops - This would be an error check for digest if some > caller called setkey function for digest algorithm. All ahash algorithms should provide a setkey function just like hash. Digest algorithms should never come down this way. When we convert digest algorithms over to ahash we should add setkey functions. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html