Hi, Patch 1/3 attached. I still can't get the line wrap problem solved. Therefore it is attached instead inline. Please note: 1. ahash_request has an extra variable 'void *info' for future uses with KASUMI 2. Any particular reason for removing ahash_nosetkey from function crypto_init_ahash_ops - This would be an error check for digest if some caller called setkey function for digest algorithm. -Loc -----Original Message----- From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] Sent: Wednesday, May 07, 2008 6:01 AM To: Loc Ho Cc: linux-crypto@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/1] CryptoAPI: Add Async Hash Support On Tue, Apr 22, 2008 at 10:23:23AM -0700, Loc Ho wrote: > > They are attached instead inline until I figure out how to not wrap long > line. Thanks. I've finally finished testing and integrating it. I've merged them into one patch and dropped unrelated white-space changes. You can resubmit those in a separate patch. Could you please recheck this and if everything looks OK then send it to me again with a sign-off? Oh and if you don't mind please split the tcrypt and cryptd parts into separate patches since they're conceptually distinct from the API bits. Finally a proper description before each patch would be nice :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Attachment:
0001-CRYPTO-hash-Add-asynchronous-hash-support.patch
Description: 0001-CRYPTO-hash-Add-asynchronous-hash-support.patch
