Re: [patch 2/2] remove similar aes glue code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Herbert Xu | 2007-11-11 09:18:56 [+0800]:

>On Sat, Nov 10, 2007 at 10:20:00PM +0100, Sebastian Siewior wrote:
>> * Herbert Xu | 2007-11-10 19:19:55 [+0800]:
>> 
>> >On Sat, Nov 03, 2007 at 11:05:03AM +0100, Sebastian Siewior wrote:
>> >>
>> >>  static struct crypto_alg aes_alg = {
>> >> -	.cra_name		=	"aes",
>> >> -	.cra_driver_name	=	"aes-x86_64",
>> >> +	.cra_name			=	"aes",
>> >> +	.cra_driver_name	=	"aes-asm",
>> >
>> >This is bad because the algorithm name no longer matches the module
>> >name.
>> This is case for every aes driver after I renamed them. Or am I missing
>> something? You are not talking about cra_drive_name are you?
>
>I meant the cra_driver_name.  Both names can be used to find
>the algorithm.
I checked it and cra_driver_name is only used for compare. I think you
could use something like "cbc(aes-asm)" but this would only work on x86.
Is there something I am overlooking?
I have no problem with adding another alias but atleast I would like
understand it :)
>
>Thanks,

Sebastian
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux