On Sat, Nov 10, 2007 at 10:20:00PM +0100, Sebastian Siewior wrote:
> * Herbert Xu | 2007-11-10 19:19:55 [+0800]:
>
> >On Sat, Nov 03, 2007 at 11:05:03AM +0100, Sebastian Siewior wrote:
> >>
> >> static struct crypto_alg aes_alg = {
> >> - .cra_name = "aes",
> >> - .cra_driver_name = "aes-x86_64",
> >> + .cra_name = "aes",
> >> + .cra_driver_name = "aes-asm",
> >
> >This is bad because the algorithm name no longer matches the module
> >name.
> This is case for every aes driver after I renamed them. Or am I missing
> something? You are not talking about cra_drive_name are you?
I meant the cra_driver_name. Both names can be used to find
the algorithm.
Thanks,
> >I suppose we could rename the modules too, or perhaps just
> >add an alias?
>
> We can't rename the asm optimized module to aes.ko. Well we could but
> this might be little ugly since we allready haven an alias for AES
> provided by the generic algorithm (on which this algorithm depends on).
> If you are talking about adding an alias which one should it be?
> We allready have an AES alias in the glue code.
You could add an aes-asm alias.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
