* Herbert Xu | 2007-10-05 23:10:51 [+0800]: >On Fri, Oct 05, 2007 at 03:12:10PM +0200, Sebastian Siewior wrote: >> Loading the crypto algorithm by the alias instead of by module directly >> has the advantage that all possible implementations of this algorithm >> are loaded automatically and the crypto API can choose the best one >> depending on its priority. >> Additionally it ensures that the generic implementation as well as the >> HW driver (if available) is loaded in case the HW driver needs the >> generic version as fallback in corner cases. >> Also remove the probe for sha1 in padlock's init code. >> Quote from Herbert: >> The probe is actually pointless since we can always probe when >> the algorithm is actually used which does not lead to dead-locks >> like this. > >Thanks. I'll apply this tomorrow. > >BTW, the dead-lock does exist after all. The lock that's held >is the user-space file lock held by modprobe. Assuming that >padlock-sha comes before sha in the alias list, then the second >modprobe will hit padlock-sha again and dead-lock. Really, hmm. That CRYPTO_ALG_NEED_FALLBACK flag is unused than? I try to remove the hardware specific code and test the via-sha code as it once I have some time in my hands :) >Cheers, Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
