Tejun Heo wrote: > Eric W. Biederman wrote: >> This modifies sysfs_rename_dir to use sysfs_addrm_start/sysfs_addrm_finish >> making it more like the rest of the sysfs directory manipulation functions. >> >> This moves the entire rename operation inside of sysfs_mutex removing >> the need to grab i_mutex, and incidentally this kills one s_dentry use. >> >> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> > > Looks good. > > Acked-by: Tejun Heo <htejun@xxxxxxxxx> > Just one afterthought. addrm_start/finish are basically used as wrapper to lock both sysfs_mutex and i_mutex. It might be better to just open code them. sysfs_move_dir() has to open code locking anyway and IMHO it's better to keep rename and move look similar. Thanks. -- tejun _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
