Eric W. Biederman wrote: > Besides being a good general cleanup the ultimate effect > of this patch is that sysfs_get_inode now gives you a > usable inode that doesn't need any further initialization > to be useful. > > Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> I generally like it. The only nits are that I think we're better off keeping the function in fs/sysfs/dir.c as all the interesting parts are there anyway and sysfs_instantiate() can just die. The function is just a remnant of days where inode initialization was scattered all over the place. Thanks. -- tejun _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers