On Mon, Aug 1, 2022 at 12:11 PM Enzo Matsumiya <ematsumiya@xxxxxxx> wrote: > > On 08/01, Steve French wrote: > >On Mon, Aug 1, 2022 at 10:49 AM Tom Talpey <tom@xxxxxxxxxx> wrote: > >> > >> I think a big chunk of cifsfs.c, and a boatload of module params, > >> can be similarly conditionalized. > > > >Good point - and will make it easier to read as well. Perhaps I can > >move most of cifsfs.c to smbfs.c and just leave smb1 specific > >things in cifsfs.c so it can be optionally compiled out? > > I'd suggest "core.c" (but smbfs.h) so it doesn't conflict with module name, aah - good point -- Thanks, Steve