On 08/01, Enzo Matsumiya wrote:
On 08/01, ronnie sahlberg wrote:
Small nit : in cifssmb.c why comment out smb2proto.h, just delete the line.
Agreed.
@Steve also, why ifdef everything instead of putting everything in a
"smb1" dir and just use Kconfig to build that dir? IOW like I did in in
my branch https://github.com/ematsumiya/linux/commits/refactor
Just to be clear on the advantages of this: clean code (reduce those
ifdefs by a lot), move shared code to module top-level and fixes to
those code gets higher priority to the newer protocol versions, proper
isolation of smb1 code (separate dir) instead of a "virtual" one (ifdefs),
all that while we can also maintain history if using "git mv" to move
SMB1 specific files.
