Small nit : in cifssmb.c why comment out smb2proto.h, just delete the line. Otherwise, a good first step. Good work. Reviewed-by me. Maybe we should now also add a warning to smb1 mounts that smb1 will be disabled by default in say jan 2024 ? On Mon, 1 Aug 2022 at 16:28, Steve French <smfrench@xxxxxxxxx> wrote: > > Currently much of the smb1 code is built even when > CONFIG_CIFS_ALLOW_INSECURE_LEGACY is disabled. > > Move cifssmb.c to only be compiled when insecure legacy is disabled, > and move various SMB1/CIFS helper functions to that ifdef. Some > functions that were not SMB1/CIFS specific needed to be moved out of > cifssmb.c > > This shrinks cifs.ko by more than 10% which is good - but also will > help with the eventual movement of the legacy code to a distinct > module. > > See attached. > > -- > Thanks, > > Steve
