Hi Adam, Adam Harvey <adam@xxxxxxxxxxxxxxx> writes: > In 24e0a1eff9e2, the noauto option was missed when migrating to the new > mount API. As a result, users with noauto in their fstab mount options > are now unable to mount cifs filesystems, as they'll receive an "Unknown > parameter" error. > > This restores the old behaviour of ignoring noauto if it's given. I was looking at other fs code and it seems no one explicitely parses auto/noauto. Any idea why? This looks like it could be handled somewhere else. Also I would have expected fsparam_flag_no("auto", Opt_ignore) to allow for both auto and noauto. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)