Re: [PATCH] cifs: do not fail __smb_send_rqst if non-fatal signals are pending

[Pavel Shilovsky <piastryyy@xxxxxxxxx>]

пн, 25 янв. 2021 г. в 09:21, Shyam Prasad N <nspmangalore@xxxxxxxxx>:
>
> One more point:
>         if (signal_pending(current) && (total_len != send_length)) {
> <<<<< Shouldn't this be replaced by fatal_signal_pending too?
>                 cifs_dbg(FYI, "signal is pending after attempt to send\n");
> -               rc = -EINTR;
> +               rc = -ERESTARTSYS;
>         }
>

At this point we are returning from the function anyway and would want
to return a proper error code if a signal is pending. So, I think
checking for any signal is correct here.

--
Best regards,
Pavel Shilovsky