On Wed, 27 Jan 2021 at 02:56, Aurélien Aptel <aaptel@xxxxxxxx> wrote:
>
> Hi Adam,
>
> Adam Harvey <adam@xxxxxxxxxxxxxxx> writes:
> > In 24e0a1eff9e2, the noauto option was missed when migrating to the new
> > mount API. As a result, users with noauto in their fstab mount options
> > are now unable to mount cifs filesystems, as they'll receive an "Unknown
> > parameter" error.
> >
> > This restores the old behaviour of ignoring noauto if it's given.
>
> I was looking at other fs code and it seems no one explicitely parses
> auto/noauto. Any idea why? This looks like it could be handled somewhere
> else.
Honestly, I have no idea. I'm just a regular user trying to get his
music share to mount on 5.11-rc5. :)
> Also I would have expected fsparam_flag_no("auto", Opt_ignore) to allow
> for both auto and noauto.
Good catch! I misread the fstab manpage last night and thought there
wasn't a matching "auto". I'll send an updated patch that supports
both.
Thanks,
Adam
