On Fri, Oct 28, 2011 at 8:58 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote: > On Thu, 27 Oct 2011 17:15:15 -0400 > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > >> I'm not complaining about Pavel - he has generally done outstanding >> work. >> >> But patches posted the first time in that form two days ago (and the >> first time completely for a long time) are simply not suitable for > > I agree. It's definitely premature to merge this series. The patches > themselves have never been posted to the list AFAICT, though Pavel has > on occasion posted a link to his git tree. That's not the same thing > however. As a general rule... > > "If it's not on the list, then it doesn't exist" Be fair to Pavel ... I trivially found individual smb2 patches on list as far back as February (probably earlier on the other mailing list), the stats patch I redid to include Christoph's feedback and Pavel incorporated much feedback this summer from at least four developers and from the two test events I attended. You gave patch feedback to Pavel multiple times this summer. And with him breaking the patches into smaller pieces, I can see why he was reluctant to post a 50 patch series, but posted a link to them. Posting the series individually is usually better, but this last respin was mainly to deal with merge conflicts from your large (nicely done) async series and other recent cifs patches. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
