I have reviewed most of it and am fine with it going out of your tree. On Fri, Jun 24, 2011 at 5:54 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: >> > Al, what is the status of your patchset? Note, that you can add my >> > "Acked-by: Pavel Shilovsky <piastryyy@xxxxxxxxx>" tag as well if you >> > need it. >> > >> >> Yes, I've looked over the set and it looks good to me. Nice cleanup, >> Al. You can add my: >> >> Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> > > OK... The patchset fixes breakage that got into cifs ->mount() since > cifs had started to play with shared superblocks - sget() races, leaks, > etc. Commit dates are recent due to added Acked-by and Reviewed-by; > other than that, it's an exact copy of the stuff that sat in for-next. > What is the proper way to deal with such situations, BTW? I know that > you seriously dislike being asked to pull just-created commits, but > the normal reasons do not apply in this case... Please, pull from > the usual place - > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus > > Shortlog: > Al Viro (15): > take bdi setup/destruction into cifs_mount/cifs_umount > cifs: double free on mount failure > cifs: don't leak nls on mount failure > cifs: don't pass superblock to cifs_mount() > cifs: leak on mount if we share superblock > cifs: allocate mountdata earlier > cifs: initialize ->tlink_tree in cifs_setup_cifs_sb() > sanitize cifs_umount() prototype > cifs: pull cifs_mount() call up > cifs: move cifs_umount() call into ->kill_sb() > cifs: pull freeing mountdata/dropping nls/freeing cifs_sb into cifs_umount() > cifs: close sget() races > cifs: more breakage on mount failures > cifs: tidy cifs_do_mount() up a bit > cifs: propagate errors from cifs_get_root() to mount(2) > > Diffstat: > fs/cifs/cifs_fs_sb.h | 1 + > fs/cifs/cifsfs.c | 156 +++++++++++++++++++++----------------------------- > fs/cifs/cifsproto.h | 8 +- > fs/cifs/connect.c | 49 +++++++++------- > 4 files changed, 98 insertions(+), 116 deletions(-) > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
