On Tue, 2023-07-18 at 09:56 +0200, Markus Schneider-Pargmann wrote: > Hi Marc, Simon and everyone, > > v5 got a rebase on v6.5 with some small style fixes as pointed out in > v4. > > It is tested on tcan455x but I don't have hardware with mcan on the > SoC > myself so any testing is appreciated. > > The series implements many small and bigger throughput improvements > and > adds rx/tx coalescing at the end. > > Based on v6.5-rc1. Also available at > https://gitlab.baylibre.com/msp8/linux/-/tree/topic/mcan-optimization/v6.5?ref_type=heads For the whole series: Tested-by: Martin Hundebøll <martin@xxxxxxxxxx> Thanks, Martin > Changes in v5: > - Add back parenthesis in m_can_set_coalesce(). This will make > checkpatch unhappy but gcc happy. > - Remove unused fifo_header variable in m_can_tx_handler(). > - Rebased to v6.5-rc1 > > Changes in v4: > - Create and use struct m_can_fifo_element in m_can_tx_handler > - Fix memcpy_and_pad to copy the full buffer > - Fixed a few checkpatch warnings > - Change putidx to be unsigned > - Print hard_xmit error only once when TX FIFO is full > > Changes in v3: > - Remove parenthesis in error messages > - Use memcpy_and_pad for buffer copy in 'can: m_can: Write transmit > header and data in one transaction'. > - Replace spin_lock with spin_lock_irqsave. I got a report of a > interrupt that was calling start_xmit just after the netqueue was > woken up before the locked region was exited. spin_lock_irqsave > should > fix this. I attached the full stack at the end of the mail if > someone > wants to know. > - Rebased to v6.3-rc1. > - Removed tcan4x5x patches from this series. > > Changes in v2: > - Rebased on v6.2-rc5 > - Fixed missing/broken accounting for non peripheral m_can devices. > > previous versions: > v1 - > https://lore.kernel.org/lkml/20221221152537.751564-1-msp@xxxxxxxxxxxx > v2 - > https://lore.kernel.org/lkml/20230125195059.630377-1-msp@xxxxxxxxxxxx > v3 - > https://lore.kernel.org/lkml/20230315110546.2518305-1-msp@xxxxxxxxxxxx/ > v4 - > https://lore.kernel.org/lkml/20230621092350.3130866-1-msp@xxxxxxxxxxxx/ > > Markus Schneider-Pargmann (12): > can: m_can: Write transmit header and data in one transaction > can: m_can: Implement receive coalescing > can: m_can: Implement transmit coalescing > can: m_can: Add rx coalescing ethtool support > can: m_can: Add tx coalescing ethtool support > can: m_can: Use u32 for putidx > can: m_can: Cache tx putidx > can: m_can: Use the workqueue as queue > can: m_can: Introduce a tx_fifo_in_flight counter > can: m_can: Use tx_fifo_in_flight for netif_queue control > can: m_can: Implement BQL > can: m_can: Implement transmit submission coalescing > > drivers/net/can/m_can/m_can.c | 517 +++++++++++++++++++++++++------- > -- > drivers/net/can/m_can/m_can.h | 35 ++- > 2 files changed, 418 insertions(+), 134 deletions(-) > > > base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
