On 15.09.2022 15:27:11, Andy Shevchenko wrote: > > > If you change the name of the file, the module will be > > > changed and hence the breakage. > > > > > > That said, NAK from me (as I do usually the opposite change). > > > > Let's look at the diffstat: > > > > These are serial line disciplines, they have their own ID: > > drivers/net/can/can327.c | 4 ++-- > > drivers/net/can/slcan/slcan-core.c | 14 ++++++++------ > > > > This might be a problem, it's a platform driver: > > drivers/net/can/softing/softing_main.c | 4 ++-- > > > > It should be no problem for USB devices, right? > > drivers/net/can/usb/ems_usb.c | 4 ++-- > > drivers/net/can/usb/esd_usb.c | 2 +- > > drivers/net/can/usb/etas_es58x/es58x_core.c | 14 +++++--------- > > drivers/net/can/usb/gs_usb.c | 6 +++--- > > drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +- > > drivers/net/can/usb/usb_8dev.c | 4 ++-- > > I agree with your grouping and analysis. This is minor anyway, but > better to have it more robust. So, yes, with USB I don't believe it > would be an issue, but for platform driver it might be. This series is in >= v6.0 and there are several platform drivers that use KBUILD_MODNAME for .name before this series. I'll take care to revert that change on the softing driver and prepare patches for the others. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
