Tue, Jul 26, 2022 at 05:26:57PM +0900, Vincent Mailhol kirjoitti: > This is a cleanup series. > > The patches 1 to 8 get rid of any hardcoded strings and instead relies > on the KBUILD_MODNAME macros to get the device name. Patch 9 replaces > the ES58X_MODULE_NAME macro with KBUILD_MODNAME in > etas_es58x. Finally, also in etas_es58x, patch 10 removes the > DRV_VERSION so that the module uses the default behavior and advertise > the kernel version instead of a custom version. I guess you all understand that this is potential ABI breakage. The driver can be instantiated by its name (for matching purposes) from board files or MFD cell. If you change the name of the file, the module will be changed and hence the breakage. That said, NAK from me (as I do usually the opposite change). -- With Best Regards, Andy Shevchenko