[PATCH v2 00/10] can: remove litteral strings used for driver names and remove DRV_VERSION

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a cleanup series.

The patches 1 to 8 get rid of any hardcoded strings and instead relies
on the KBUILD_MODNAME macros to get the device name. Patch 9 replaces
the ES58X_MODULE_NAME macro with KBUILD_MODNAME in
etas_es58x. Finally, also in etas_es58x, patch 10 removes the
DRV_VERSION so that the module uses the default behavior and advertise
the kernel version instead of a custom version.


* Changelog *

v1 -> v2:

  * The patch for esd_usb contained some changes for ems_usb.

  * v1 assumed that KBUILD_MODNAME could only be used when the file
    basename and the module had the same name (e.g. vcan.c for the
    vcan.ko). The fact is that KBUILD_NAME extends to the module name
    and can thus be used even if the basename is different
    (e.g. slcan-core.c and slcan.ko)

  * Add patch #9: can: etas_es58x: replace ES58X_MODULE_NAME with
    KBUILD_MODNAME

v1:

This series are the first 9 patches of:
https://lore.kernel.org/linux-can/20220725133208.432176-1-mailhol.vincent@xxxxxxxxxx/T/

The initial intent of those 9 patches was to do so cleanup in order to
implement ethtool_ops::get_drvinfo but this appeared to be useless:
https://lore.kernel.org/linux-can/20220725140911.2djwxfrx3kdmjeuc@xxxxxxxxxxxxxx/

Instead, those patch are send as a standalone series


Vincent Mailhol (10):
  can: can327: use KBUILD_MODNAME instead of hard coded names
  can: ems_usb: use KBUILD_MODNAME instead of hard coded names
  can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded
    names
  can: softing: use KBUILD_MODNAME instead of hard coded names
  can: esd_usb: use KBUILD_MODNAME instead of hard coded names
  can: gs_ubs: use KBUILD_MODNAME instead of hard coded names
  can: kvaser_usb: use KBUILD_MODNAME instead of hard coded names
  can: ubs_8dev: use KBUILD_MODNAME instead of hard coded names
  can: etas_es58x: replace ES58X_MODULE_NAME with KBUILD_MODNAME
  can: etas_es58x: remove DRV_VERSION

 drivers/net/can/can327.c                         |  4 ++--
 drivers/net/can/slcan/slcan-core.c               | 14 ++++++++------
 drivers/net/can/softing/softing_main.c           |  4 ++--
 drivers/net/can/usb/ems_usb.c                    |  4 ++--
 drivers/net/can/usb/esd_usb.c                    |  2 +-
 drivers/net/can/usb/etas_es58x/es58x_core.c      | 14 +++++---------
 drivers/net/can/usb/gs_usb.c                     |  6 +++---
 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c |  2 +-
 drivers/net/can/usb/usb_8dev.c                   |  4 ++--
 9 files changed, 26 insertions(+), 28 deletions(-)

-- 
2.35.1




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux