This series revolves around ethtool and timestamping. Its ultimate
goal is that the timestamping implementation within socketCAN meets
the specification of other network drivers in the kernel. This way,
tcpdump or other tools derived from libpcap can be used to do
timestamping on CAN devices.
* Example on a device with hardware timestamp support *
Before this series:
| # tcpdump -j adapter_unsynced -i can0
| tcpdump: WARNING: When trying to set timestamp type
| 'adapter_unsynced' on can0: That type of time stamp is not supported
| by that device
After applying this series, the warning disappears and tcpdump can be
used to get RX hardware timestamps.
This series is articulated in three major parts.
* Part 1: Add TX software timestamps and report the software
timestamping capabilities through ethtool.
All the drivers using can_put_echo_skb() already support TX software
timestamps. However, the five drivers not using this function (namely
can327, janz-ican3, slcan, vcan and vxcan) lack such support. Patch 1
to 4 adds this support. Finally, patch 5 advertises the timesamping
capabilities of all drivers which do not support hardware timestamps.
* Part 2: add TX hardware timestapms
This part is a single patch. In SocetCAN TX hardware is equal to the
RX hardware timestamps of the corresponding loopback frame. Reuse the
TX hardware timestamp to populate the RX hardware timestamp. While the
need of this feature can be debatable, we implement it here so that
generic timestamping tools which are agnostic of the specificity of
SocketCAN can still obtain the value. For example, tcpdump expects for
both TX and RX hardware timestamps to be supported in order to do:
| # tcpdump -j adapter_unsynced -i canX
* Part 3: report the hardware timestamping capabilities and implement
the hardware timestamps ioctls.
The kernel documentation specifies in [1] that, for the drivers which
support hardware timestamping, SIOCSHWTSTAMP ioctl must be supported
and that SIOCGHWTSTAMP ioctl should be supported. Currently, none of
the CAN drivers do so. This is a gap.
Furthermore, even if not specified, the tools based on libpcap
(e.g. tcpdump) also expect ethtool_ops::get_ts_info to be implemented.
This last part first adds some generic implementation of
net_device_ops::ndo_eth_ioctl and ethtool_ops::get_ts_info which can
be used by the drivers with hardware timestamping capabilities.
It then uses those generic functions to add ioctl and reporting
functionalities to the drivers with hardware timestamping support
(namely: mcp251xfd, etas_es58x, kvaser_{pciefd,usb}, peak_{canfd,usb})
[1] Kernel doc: Timestamping, section 3.1 "Hardware Timestamping
Implementation: Device Drivers"
Link: https://docs.kernel.org/networking/timestamping.html#hardware-timestamping-implementation-device-drivers
* Testing *
I also developed a tool to test all the different timestamps. For
those who would also like to test it, please have a look at:
https://lore.kernel.org/linux-can/20220725134345.432367-1-mailhol.vincent@xxxxxxxxxx/T/
* Changelog *
v2 -> v3:
* The c_can, flexcan, mcp251xfd and the slcan drivers already
declared a struct ethtool_ops. Do not declare again the same
structure and instead populate the .get_ts_info() field of the
existing structures.
v1 -> v2:
* First series had a patch to implement
ethtool_ops::get_drvinfo. This proved to be useless. This patch
was removed and all the clean-up patches made in preparation of
that one were moved to a separate series:
https://lore.kernel.org/linux-can/20220725153124.467061-1-mailhol.vincent@xxxxxxxxxx/T/#u
Vincent Mailhol (14):
can: can327: add software tx timestamps
can: janz-ican3: add software tx timestamp
can: slcan: add software tx timestamps
can: v(x)can: add software tx timestamps
can: tree-wide: advertise software timestamping capabilities
can: dev: add hardware TX timestamp
can: dev: add generic function can_ethtool_op_get_ts_info_hwts()
can: dev: add generic function can_eth_ioctl_hwts()
can: mcp251xfd: advertise timestamping capabilities and add ioctl
support
can: etas_es58x: advertise timestamping capabilities and add ioctl
support
can: kvaser_pciefd: advertise timestamping capabilities and add ioctl
support
can: kvaser_usb: advertise timestamping capabilities and add ioctl
support
can: peak_canfd: advertise timestamping capabilities and add ioctl
support
can: peak_usb: advertise timestamping capabilities and add ioctl
support
drivers/net/can/at91_can.c | 6 +++
drivers/net/can/c_can/c_can_ethtool.c | 1 +
drivers/net/can/can327.c | 7 +++
drivers/net/can/cc770/cc770.c | 6 +++
drivers/net/can/ctucanfd/ctucanfd_base.c | 6 +++
drivers/net/can/dev/dev.c | 50 +++++++++++++++++++
drivers/net/can/dev/skb.c | 6 +++
drivers/net/can/flexcan/flexcan-ethtool.c | 1 +
drivers/net/can/grcan.c | 6 +++
drivers/net/can/ifi_canfd/ifi_canfd.c | 6 +++
drivers/net/can/janz-ican3.c | 8 +++
drivers/net/can/kvaser_pciefd.c | 7 +++
drivers/net/can/m_can/m_can.c | 6 +++
drivers/net/can/mscan/mscan.c | 1 +
drivers/net/can/pch_can.c | 6 +++
drivers/net/can/peak_canfd/peak_canfd.c | 7 +++
drivers/net/can/rcar/rcar_can.c | 6 +++
drivers/net/can/rcar/rcar_canfd.c | 6 +++
drivers/net/can/sja1000/sja1000.c | 6 +++
drivers/net/can/slcan/slcan-core.c | 2 +
drivers/net/can/slcan/slcan-ethtool.c | 1 +
drivers/net/can/softing/softing_main.c | 6 +++
drivers/net/can/spi/hi311x.c | 6 +++
drivers/net/can/spi/mcp251x.c | 6 +++
.../net/can/spi/mcp251xfd/mcp251xfd-core.c | 1 +
.../net/can/spi/mcp251xfd/mcp251xfd-ethtool.c | 1 +
drivers/net/can/sun4i_can.c | 6 +++
drivers/net/can/ti_hecc.c | 6 +++
drivers/net/can/usb/ems_usb.c | 6 +++
drivers/net/can/usb/esd_usb.c | 6 +++
drivers/net/can/usb/etas_es58x/es58x_core.c | 9 +++-
drivers/net/can/usb/gs_usb.c | 2 +
drivers/net/can/usb/kvaser_usb/kvaser_usb.h | 1 +
.../net/can/usb/kvaser_usb/kvaser_usb_core.c | 27 +++++++++-
drivers/net/can/usb/mcba_usb.c | 6 +++
drivers/net/can/usb/peak_usb/pcan_usb.c | 2 +
drivers/net/can/usb/peak_usb/pcan_usb_core.c | 12 ++++-
drivers/net/can/usb/peak_usb/pcan_usb_core.h | 4 ++
drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 +
drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 +
drivers/net/can/usb/ucan.c | 6 +++
drivers/net/can/usb/usb_8dev.c | 6 +++
drivers/net/can/vcan.c | 8 +++
drivers/net/can/vxcan.c | 8 +++
drivers/net/can/xilinx_can.c | 6 +++
include/linux/can/dev.h | 4 ++
46 files changed, 295 insertions(+), 5 deletions(-)
--
2.35.1
