Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.07.2021 11:12:42, Pavel Skripkin wrote:
> Can You try the following patch?

Can you create a proper patch with you S-o-b?

> diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
> index a45865bd7254..a1a154c08b7f 100644
> --- a/drivers/net/can/usb/mcba_usb.c
> +++ b/drivers/net/can/usb/mcba_usb.c
> @@ -653,6 +653,8 @@ static int mcba_usb_start(struct mcba_priv *priv)
>  			break;
>  		}
>  
> +		urb->transfer_dma = buf_dma;
> +
>  		usb_fill_bulk_urb(urb, priv->udev,
>  				  usb_rcvbulkpipe(priv->udev, MCBA_USB_EP_IN),
>  				  buf, MCBA_USB_RX_BUFF_SIZE,
> 
> 
> 
> I've added Marc to this discussion, I believe, he can help us, since he
> is CAN maintainer.

Yasushi, please test and post your Tested-by here. After Pavel posts a
proper patch and you tested it, I'll forward it to net/master, then it
will be applied to the stable kernels. Debian can even pick up the patch
earlier.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux