Re: [PATCH] can: bittiming: fix two grammar mistakes in documentation for struct can_tdc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed. 16 Jun 2021 at 22:33, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> On 16.06.2021 21:40:57, Vincent Mailhol wrote:
> > This patch fixes two grammar errors in the documentation for struct
> > can_tdc.
> >
> > First grammar error: add a missing third person 's'.
> >
> > Second grammar error: replace "such as" by "such that". The intent is
> > to give a condition, not an example.
> >
> > Fixes: 289ea9e4ae59 ("can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)")
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> > ---
> > Hi Marc,
> >
> > If that makes sense to you, feel free to squash this in your other
> > patch.
>
> Makes sense. I've added you as Co-developed-by:

Great, thank you!

> |     can: bittiming: fix documentation for struct can_tdc::tdcv

One nitpick: the title should become
|     can: bittiming: fix documentation for struct can_tdc
(without the ::tdcv) because the last fix is on tdco.

> |     This patch fixes a typo in the documentation for struct can_tdc::tdcv.
> |     The number "0" refers to automatic mode not the letter "O".
> |
> |     Further two grammar errors in the documentation for struct can_tdc are
> |     fixed.
> |
> |     First grammar error: add a missing third person 's'.
> |
> |     Second grammar error: replace "such as" by "such that". The intent is
> |     to give a condition, not an example.
> |
> |     Fixes: 289ea9e4ae59 ("can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)")
> |     Link: https://lore.kernel.org/r/20210616095922.2430415-1-mkl@xxxxxxxxxxxxxx
> |     Link: https://lore.kernel.org/r/20210616124057.60723-1-mailhol.vincent@xxxxxxxxxx
> |     Co-developed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> |     Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> |     Acked-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> |     Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>
> regards,
> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux