On Tue, May 04, 2021 at 10:05:19PM +0200, Marc Kleine-Budde wrote:
> This patch silences the following clang warning:
>
> | drivers/net/can/spi/mcp251x.c:1333:17: warning: cast to smaller integer type
> | 'enum mcp251x_model' from 'const void *' [-Wvoid-pointer-to-enum-cast]
> | priv->model = (enum mcp251x_model)match;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8de29a5c34a5 ("can: mcp251x: Make use of device property API")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---
> drivers/net/can/spi/mcp251x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
> index 492f1bcb0516..275b2ddab143 100644
> --- a/drivers/net/can/spi/mcp251x.c
> +++ b/drivers/net/can/spi/mcp251x.c
> @@ -1343,7 +1343,7 @@ static int mcp251x_can_probe(struct spi_device *spi)
> priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES |
> CAN_CTRLMODE_LOOPBACK | CAN_CTRLMODE_LISTENONLY;
> if (match)
> - priv->model = (enum mcp251x_model)match;
> + priv->model = (enum mcp251x_model)(kernel_ulong_t)match;
Usually we use uintptr_t, but either way
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks!
> else
> priv->model = spi_get_device_id(spi)->driver_data;
> priv->net = net;
>
> base-commit: 9d31d2338950293ec19d9b095fbaa9030899dcb4
> prerequisite-patch-id: 2d99a92f9c04a76341ba84b5f4924c2ba03bdd88
> prerequisite-patch-id: 6dbb40c8b889604bf57aa2374f34290b247b7d28
> prerequisite-patch-id: 24ff9c746552e4a8e100200f13bb1732990392a3
> --
> 2.30.2
>
>
--
With Best Regards,
Andy Shevchenko
