Hi Marc, On Wed. 17 Mar 2021 at 00:29, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > On 17.03.2021 00:16:01, Vincent MAILHOL wrote: > > > I just had a look at the ethtool-netlink interface: > > > > > > | Documentation/networking/ethtool-netlink.rst > > > > > > this is much better designed than the CAN netlink interface. It was done > > > by the pros and much later than CAN. :D So I'd like to have a similar > > > structure for new CAN netlink stuff. > > > > > > So I think I'll remove this patch for now from can-next-testing. The > > > kernel internal interface to tdc is still OK, we can leave it as is and > > > change it if needed. But netlink is user space and I'd like to have it > > > properly designed. > > > > Understood. However, I will need more time to read and understand > > the ethtool-netlink interface. The new patch will come later, I > > do not know when. > > No Problem I started to look at Ethtool netlink, but as far as my understanding goes, this seems purely restricted to the ethtool application (i.e. not to iproute2). I double checked the latest versions of iproute2 but there isn’t a single #include <linux/ethtool_netlink.h> nor anything else related to that new API. Please let me know if I missed the point. Yours sincerely, Vincent
