Re: [PATCH] can: mcp251x: fix support for half duplex SPI host controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 30, 2021 at 3:02 AM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> Some SPI host controllers do not support full-duplex SPI transfers.
>
> The function mcp251x_spi_trans() does a full duplex transfer. It is
> used in several places in the driver, where a TX half duplex transfer
> is sufficient.
>
> To fix support for half duplex SPI host controllers, this patch
> introduces a new function mcp251x_spi_write() and changes all callers
> that do a TX half duplex transfer to use mcp251x_spi_write().
>
> Fixes: e0e25001d088 ("can: mcp251x: add support for half duplex controllers")
> Cc: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Reported-by: Gerhard Bertelsmann <info@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---

Mi Marc and Gerhard,

So was the issue being resolved here that there was another SPI host
controller that wasn't advertising that it was half duplex only or was
something else wrong with e0e25001d088 ("can: mcp251x: add support for
half duplex controllers")?

Best regards,

Tim



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux