On Fri, Jun 26, 2020 at 04:41:53PM +0200, Marc Kleine-Budde wrote: > On 6/26/20 3:32 PM, Manivannan Sadhasivam wrote: > > On Mon, Jun 22, 2020 at 01:46:03PM +0200, Marc Kleine-Budde wrote: > >> This patch add support for the Microchip MCP25xxFD SPI CAN controller family. > >> > >> Pending-Tested-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx> > >> Pending-Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > >> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > > > Could you please split this patch into multiple ones? Having ~4k lines for a > > patch makes it difficult to review. I know that some parts are difficult to > > split (happened with my series as well) but anything below 1k should be fine. > > For now I split the regmap and crc16 into one patch, the core file into a > separate patch. > > See: > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=mcp25xxfd-45 > > If you want to have it in smaller pieces I'll need more time to figure out a > sensible way to split the driver. > Can you please post the split version here so that I can do a formal review? Thanks, Mani > regards, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
