On do, 11 jun 2020 18:26:19 +0200, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspired (or taken) from the previous iterations posted by Martin Sperl. > > I've trimmed down the parts which are not necessary for the initial version > > to ease review. Still the series is relatively huge but I hope to get some > > reviews (post -rcX ofc!). > > > > Link to the origial series posted by Martin: > > https://www.spinics.net/lists/devicetree/msg284462.html > > > > I've not changed the functionality much but done some considerable amount of > > cleanups and also preserved the authorship of Martin for all the patches he has > > posted earlier. This series has been tested on 96Boards RB3 platform by myself > > and Martin has tested the previous version on Rpi3 with external MCP2517FD > > controller. > > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is the one I'm hoping to mainline soon. > > Can you give it a try? > > https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41 Hi Marc, I'm in the process of getting a Variscite imx8m mini SOM online, with MCP2517FD. The 4.19 kernel that comes with it, has a driver that is clearly inspired by the one of Martin Sperl (not investigated too much yet). I have problems of probing the chip when the bus is under full load (under not full load, the probing only occasionally fails) due to the modeswitch test. Is there a real difference in yours between the rpi and sunxi branches? Is there much evolution since -36 or would you mind to backport your latest -42 to 4.19? I will work on this the upcoming days. I can't do extensive tests, but rather a works-for-me test that includes bitrate probe. I only have 1 such board right now, and no other FD hardware. Kurt > > Marc
