Re: [PATCH] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Murphy <dmurphy@xxxxxx>, linux-can@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
From: Daniels Umanovskis <daniels@xxxxxxxxxxxxx>
Date: Fri, 3 Apr 2020 17:05:52 +0200
In-reply-to: <e92799d6-06cf-6b78-0f1b-e85e4710c763@ti.com>
References: <20200403144602.8494-1-daniels@umanovskis.se> <e92799d6-06cf-6b78-0f1b-e85e4710c763@ti.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

That's more concise and arguably clearer. Sending v2.

On 2020-04-03 16:44, Dan Murphy wrote:

How about just returning the value of tcan4x5x_write.. and remove thereturn ret; below
Dan

References:
- [PATCH] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
  - From: Daniels Umanovskis
- Re: [PATCH] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
  - From: Dan Murphy

Prev by Date: [PATCH] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
Next by Date: [PATCH v2] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
Previous by thread: Re: [PATCH] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
Next by thread: [PATCH v2] can: tcan4x5x: tcan4x5x_clear_interrupts: remove redundant if statement
Index(es):
- Date
- Thread

[Index of Archives] [Automotive Discussions] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [CAN Bus]

Powered by Linux