Sean
On 12/9/19 2:02 PM, Sean Nyekjaer wrote:
On 09/12/2019 20.53, Dan Murphy wrote:
Sean
On 12/9/19 1:29 PM, Sean Nyekjaer wrote:
In m_can_config_endisable the CSR bit cleared 2 times while enabling
configuration mode.
The CSR should always be cleared when writing to the CCCR register.
According to the datasheet:
If a Read-Modify-Write operation is performed in Standby mode a
CSR = 1 will be read back but a 0 should be written to it.
I am not understanding why you need to have this statement in the
commit message.
And are you referring to the Bosch IP data sheet or the TCAN data sheet?
TCAN :)
If it is the TCAN data sheet then this reference may not apply to the
MMIO version.
It would be best to denote which datasheet you are talking about here.
Other then that I agree with the change and will ACK once I
understand what data sheet you are talking about.
This patch is basically removal of some duplicate code, the register
write functions will write exactly the same as before...
No functional changes have been made.
And I agree and understand the change just not the commit.
Maybe it's easier to see when reading drivers/net/can/m_can/m_can.c
before and after this patch :-)
I can change the commit msg to whatever you will like to make this
change less confusing...
/Sean
Its only confusing because what you are changing is for the MCAN IP code
and is not specific to TCAN. The change affects all devices that
register to the m_can framework.
Referencing the TCAN data sheet for the Bosch IP implementation is not
correct.
All the commit message should say is basically what the $subject says
because that is all it is doing.
Dan
