On 10/10/19 00:02 AM, Marc Kleine-Budde wrote: > Please send patches vis git send-email if you email setup allows. This makes review easier. I will, sorry for the inconvenience. >> 1. How to handle power management? Does the driver have to restore the >> previous gpio state? > I'm not sure if a framework takes care of this. Have you had a look at other GPIO drivers in drivers/gpio: > gpio-74x164.c > gpio-max3191x.c > gpio-max7301.c > gpio-mc33880.c > gpio-xra1403.c All of these seem to not handle power management at all, but others do a complete register bank restore, e.g. gpio-brcmstb.c or gpio-pxa.c. So I think it would be best to support this in the mcp251x driver as well. > Other driers use spi->modalias, too: > So I think this is ok. Ok, thanks. Regards Timo
