I found this for the V5 commit: https://www.spinics.net/lists/linux-can/msg00847.html I may have read it wrong. It sounds like the network stack is dropping them, not necessarily the "statistics" gathering. Still the driver is able to handle reception of 99.95% of all CAN frames of a 100% saturated 1MHz Can2.0 Bus with Frames with standard IDs and DLC=0 on a Raspberry Pi 3. Note that this statistics is without injection into the network stack, which then drops about 60% of all frames. On Wed, Jul 31, 2019 at 10:16 AM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > > On 7/31/19 3:38 PM, Oliver Hartkopp wrote: > > Hi all, > > > > On 31/07/2019 03.49, Tom Prohaszka wrote: > >> We are using the MCP25xxfd driver. A comment in the code indicated > >> that during testing, the network statistics were disabled to achieve > >> high utilization of the CAN bus. Another comment indicated that when > >> network statistics were re-enabled, a 60% decrease in throughput > >> occurred. > > Can you point me to these comments? > > >> My question is, how can we disable the network statistics for CAN, and > >> if not possible for CAN, globally. > > > > there seem to be tons of MCP25XXFD_DEBUGFS_STATS_*() macros. > > I'm not sure that incrementing some counters will cause a performace > degration of 60%. > > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_int.c?h=mcp25xxfd&id=9b2ffbb925a0c32ea064c0a91b6bacb33d5e877a#n131 > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_debugfs.h?h=mcp25xxfd&id=9b2ffbb925a0c32ea064c0a91b6bacb33d5e877a > > > > We had to purge all the debug stuff when mainlining the CAN subsystem > > and I wonder if this is really NEEDED. > > > > When the driver is in mainline Linux we can assume it to work - and not > > to be debugged anymore. > > > > Additionally the CAN_DEBUG_DEVICES Kconfig option could have been used > > to debug potential pitfalls. > > > > IMO the debugfs stuff should be removed completely. > > Or at least make it a per driver option. > > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | >
