Re: Disable Network Statistics - CAN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

On 31/07/2019 03.49, Tom Prohaszka wrote:
We are using the MCP25xxfd driver.  A comment in the code indicated
that during testing, the network statistics were disabled to achieve
high utilization of the CAN bus.  Another comment indicated that when
network statistics were re-enabled, a 60% decrease in throughput
occurred.

My question is, how can we disable the network statistics for CAN, and
if not possible for CAN, globally.

there seem to be tons of MCP25XXFD_DEBUGFS_STATS_*() macros.

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_int.c?h=mcp25xxfd&id=9b2ffbb925a0c32ea064c0a91b6bacb33d5e877a#n131

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/spi/mcp25xxfd/mcp25xxfd_can_debugfs.h?h=mcp25xxfd&id=9b2ffbb925a0c32ea064c0a91b6bacb33d5e877a

We had to purge all the debug stuff when mainlining the CAN subsystem and I wonder if this is really NEEDED.

When the driver is in mainline Linux we can assume it to work - and not to be debugged anymore.

Additionally the CAN_DEBUG_DEVICES Kconfig option could have been used to debug potential pitfalls.

IMO the debugfs stuff should be removed completely.

Best regards,
Oliver




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux