Re: [PATCH v1 04/25] j1939: rename addr.pgn to addr.dst_pgn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On vr, 29 mrt 2019 14:58:38 +0100, Oleksij Rempel wrote:
> diff --git a/net/can/j1939/j1939-priv.h b/net/can/j1939/j1939-priv.h
> index df058d08fe68..127b4e28b16a 100644
> --- a/net/can/j1939/j1939-priv.h
> +++ b/net/can/j1939/j1939-priv.h
> @@ -113,7 +113,7 @@ struct j1939_ecu *j1939_ecu_get_by_name_locked(struct j1939_priv *priv,
>  struct j1939_addr {
>  	name_t src_name;
>  	name_t dst_name;
> -	pgn_t pgn;
> +	pgn_t dst_pgn;
>  
>  	u8 sa;
>  	u8 da;

I considered j1939_addr like a kind of label of a packet. In j1939, a
packet has only 1 pgn.
I'm curious why you need 2.

Kurt



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux